fix(protocol-designer): editing labware on top of a module and adapter fixes #17161
+118
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address RQA-3777 RQA-3804
Overview
2 bugs were addressed here and they're related.
Test Plan and Hands on Testing
Look at the ticket and test the example, then test editing labware in general on the deck, on an adapter and on a module and make sure it all works as expected
For the 2nd bug fix, upload the attached protocol, edit the labware on top of the heater-shaker module and go back to the protocol steps and see that the heater-shaker steps don't error. The transfer steps error and that's because we no longer have the dispense labware
1.0 testing (18).json
Changelog
refine logic for when to delete and create labware
create thunk for creating module and migrating the saved step forms module id
Risk assessment
isolated fix, low