Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): editing labware on top of a module and adapter fixes #17161

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 20, 2024

address RQA-3777 RQA-3804

Overview

2 bugs were addressed here and they're related.

  1. we weren't properly regenerating labware if you edit the labware on top of the adapter but not the adapter. this PR fixes that (bug outlined in RQA-3777)
  2. if you have a protocol with module steps and you edit the labware on top of the module, the steps error because the moduleId is the old moduleId that was deleted. this PR migrates those steps to using the right moduleId

Test Plan and Hands on Testing

  1. Look at the ticket and test the example, then test editing labware in general on the deck, on an adapter and on a module and make sure it all works as expected

  2. For the 2nd bug fix, upload the attached protocol, edit the labware on top of the heater-shaker module and go back to the protocol steps and see that the heater-shaker steps don't error. The transfer steps error and that's because we no longer have the dispense labware

1.0 testing (18).json

Changelog

refine logic for when to delete and create labware
create thunk for creating module and migrating the saved step forms module id

Risk assessment

isolated fix, low

@jerader jerader requested a review from a team as a code owner December 20, 2024 15:20
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but it's fixed and looks good!

@jerader jerader merged commit ebdfc84 into chore_release-pd-8.2.3 Dec 20, 2024
14 checks passed
@jerader jerader deleted the pd_rqa-3777-3804 branch December 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants